Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons-vue props.twoToneColor type check warning #533

Open
merfais opened this issue Jul 25, 2022 · 0 comments
Open

icons-vue props.twoToneColor type check warning #533

merfais opened this issue Jul 25, 2022 · 0 comments
Assignees
@tangjinzhou
Labels
bug Something isn't working help wanted Extra attention is needed Vue

Comments

@merfais
Copy link
Contributor

merfais commented Jul 25, 2022

type twoToneColor = string | [string, string] | undefined
at code icons-vue/src/utils.ts
but, props.twoToneColor defined twoToneColor: String as PropType,
at code icons-vue/src/components/AntdIcon.tsx

console warning

image
@tangjinzhou tangjinzhou added bug Something isn't working help wanted Extra attention is needed labels Aug 25, 2022
@tangjinzhou tangjinzhou self-assigned this Aug 25, 2022
merfais pushed a commit to merfais/ant-design-icons that referenced this issue Feb 13, 2023
fix: twoToneColor type check warning (ant-design#533)
62b53d4
merfais added a commit to merfais/ant-design-icons that referenced this issue Feb 13, 2023
@merfais
fix: twoToneColor type check warning (ant-design#533)
69d8e07
tangjinzhou pushed a commit that referenced this issue Oct 7, 2023
@merfais
fix: twoToneColor type check warning (#533) (#558)
dd75613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangjinzhou tangjinzhou

Labels
bug Something isn't working help wanted Extra attention is needed Vue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tangjinzhou @merfais