Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apps version fallback #4224

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix apps version fallback #4224

merged 3 commits into from
Jan 8, 2025

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 8, 2025

Describe your changes

When there's no .git dir the build script falls back to get the version string from cargo. This should use the metadata of the apps crate, but instead it was using the workspace version, which contains version used for libs.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic marked this pull request as ready for review January 8, 2025 10:42
@tzemanovic tzemanovic requested a review from brentstone January 8, 2025 10:43
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (db1e36e) to head (5bc357c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4224      +/-   ##
==========================================
- Coverage   74.59%   74.59%   -0.01%     
==========================================
  Files         342      342              
  Lines      108724   108724              
==========================================
- Hits        81102    81099       -3     
- Misses      27622    27625       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 8, 2025
@mergify mergify bot merged commit 92367b0 into main Jan 8, 2025
26 of 40 checks passed
@mergify mergify bot deleted the tomas/fix-apps-version-fallback branch January 8, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants