-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ledger app unit tests to the Namada CI #4140
Conversation
dc0a4c3
to
74e0a37
Compare
74e0a37
to
f2db3ba
Compare
chain_id in arb_chain_id(), | ||
expiration in option::of(arb_date_time_utc()), | ||
timestamp in arb_date_time_utc(), | ||
batch in arb_tx_commitments(1..10), | ||
batch in arb_tx_commitments(cmt_count), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one here 👍🏻 , we were previously generating up to 10 headers and the other arb_transaction
generators were only appending data for a single inner tx which was strange
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4140 +/- ##
==========================================
- Coverage 74.56% 74.54% -0.03%
==========================================
Files 341 341
Lines 107502 107549 +47
==========================================
+ Hits 80160 80173 +13
- Misses 27342 27376 +34 ☔ View full report in Codecov by Sentry. |
Thanks murisi! I just want to make a couple of changes to the CI workflow before merging |
Add Ledger app unit tests to the Namada CI (backport #4140)
Describe your changes
An attempt to add Ledger app unit tests to the Namada CI. These tests were created to complement the Ledger app E2E tests already in the CI at
test-e2e-with-device-automation
. Whereas the E2E tests comprehensively cover testing hardware wallet signing for a few cases, these unit tests focus on covering hardware wallet printing for hundreds of cases. More specifically, the following changes have been made:See an example run of this new job here: https://github.com/murisi/namada/actions/runs/12143664343/job/33861086521?pr=2
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo