Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fraccaman/rpc pgf payments #4126

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Fraccaman/rpc pgf payments #4126

merged 3 commits into from
Dec 29, 2024

Conversation

Fraccaman
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@Fraccaman Fraccaman requested a review from grarco December 1, 2024 13:37
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.46%. Comparing base (0512963) to head (bec431b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4126      +/-   ##
==========================================
- Coverage   74.47%   74.46%   -0.01%     
==========================================
  Files         342      342              
  Lines      107777   107783       +6     
==========================================
- Hits        80263    80258       -5     
- Misses      27514    27525      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone
Copy link
Collaborator

@Fraccaman can you put a changelog and then merge pls?

brentstone added a commit that referenced this pull request Dec 29, 2024
@brentstone brentstone added SDK merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Dec 29, 2024
@brentstone brentstone force-pushed the fraccaman/rpc-pgf-payments branch from 79a5e93 to bec431b Compare December 29, 2024 19:45
@mergify mergify bot merged commit 3d31147 into main Dec 29, 2024
23 of 25 checks passed
@mergify mergify bot deleted the fraccaman/rpc-pgf-payments branch December 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants