-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging for validator voting period #3728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
==========================================
+ Coverage 72.47% 72.49% +0.02%
==========================================
Files 338 338
Lines 104130 104190 +60
==========================================
+ Hits 75470 75536 +66
+ Misses 28660 28654 -6 ☔ View full report in Codecov by Sentry. |
75f39d6
to
2e458af
Compare
bcee781
to
374554f
Compare
brentstone
added a commit
that referenced
this pull request
Sep 4, 2024
374554f
to
6661ba1
Compare
brentstone
added a commit
that referenced
this pull request
Sep 4, 2024
6661ba1
to
79112e0
Compare
tzemanovic
approved these changes
Sep 6, 2024
79112e0
to
0877ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3474.
Also fixes the validator voting period, which was found to be slightly buggy. Fix a bug left over from #3691.
Checklist before merging
breaking::
labels