-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gas costs #3554
Update gas costs #3554
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 54.54% 54.54% -0.01%
==========================================
Files 323 323
Lines 113862 113862
==========================================
- Hits 62108 62106 -2
- Misses 51754 51756 +2 ☔ View full report in Codecov by Sentry. |
d25f23d
to
3528658
Compare
Do not merge this yet as we need to review some things with regards to native vps |
Any chance we could also add a test? Perhaps one that checks that transparent transfers cost less gas than shielded transfers or similar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider a test.
74739c5
to
1b7329c
Compare
1b7329c
to
f487a37
Compare
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
@mergify refresh |
✅ Pull request refreshed |
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d264b78 |
@mergify refresh |
✅ Pull request refreshed |
Describe your changes
v0.41.0
)Indicate on which release or other PRs this topic is based on
v0.41.0
Checklist before merging to
draft