Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of pgf stewards #3442

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Limit number of pgf stewards #3442

merged 6 commits into from
Jul 5, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jun 25, 2024

Describe your changes

Introduced a new genesis parameter to limit the number of pgf stewards.

Indicate on which release or other PRs this topic is based on

0.39.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman force-pushed the fraccaman/limit-pgf-stewards branch from dc3fb29 to 8363c34 Compare June 25, 2024 15:31
@Fraccaman Fraccaman requested a review from grarco June 25, 2024 15:33
@Fraccaman Fraccaman force-pushed the fraccaman/limit-pgf-stewards branch from 13787a9 to ed9415f Compare June 25, 2024 15:42
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 53.91%. Comparing base (5cc23b4) to head (267eda2).

Files Patch % Lines
crates/node/src/shell/governance.rs 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   53.92%   53.91%   -0.01%     
==========================================
  Files         317      317              
  Lines      107575   107612      +37     
==========================================
+ Hits        58007    58019      +12     
- Misses      49568    49593      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Jun 26, 2024
@brentstone brentstone self-requested a review June 26, 2024 23:39
brentstone
brentstone previously approved these changes Jun 26, 2024
@brentstone brentstone mentioned this pull request Jun 27, 2024
@brentstone brentstone force-pushed the fraccaman/limit-pgf-stewards branch from ead6af8 to 267eda2 Compare June 28, 2024 05:24
brentstone added a commit that referenced this pull request Jun 28, 2024
* fraccaman/limit-pgf-stewards:
  changelog: add #3442
  cleanup
  bug fix: get correct storage key
  fix genesis files
  improve logs
  added maximum amount of stewards as genesis parameter
  ci: update antithesis workflow
  ci: update antithesis workflow
brentstone added a commit that referenced this pull request Jul 4, 2024
* origin/fraccaman/limit-pgf-stewards:
  changelog: add #3442
  cleanup
  bug fix: get correct storage key
  fix genesis files
  improve logs
  added maximum amount of stewards as genesis parameter
@brentstone brentstone merged commit 32c6672 into main Jul 5, 2024
16 of 19 checks passed
@brentstone brentstone deleted the fraccaman/limit-pgf-stewards branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants