-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to create db snapshots #3383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
==========================================
+ Coverage 53.92% 53.93% +0.01%
==========================================
Files 317 317
Lines 107575 107786 +211
==========================================
+ Hits 58011 58137 +126
- Misses 49564 49649 +85 ☔ View full report in Codecov by Sentry. |
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
* bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
* origin/bat/feat/db-snapshots: addressing review comment review comments Update crates/node/src/storage/rocksdb.rs Update crates/node/src/storage/rocksdb.rs changelog [feat]: Added snapshot frequency to config [feat]: Added ability to create snapshots of rocksDb WIP
Describe your changes
Resolves the first two points of Issue #3307:
Specifically adds a config parameter that indicates after how many blocks a snapshot should be created. If set, then on the corresponding calls to
commit
, a background task is spun up that takes a snapshot of rocksDB and writes it in a convenient format to a file. This file contains metadata of how to be broken up into chunks. Once a new snapshot is created, older snapshots are removed.Indicate on which release or other PRs this topic is based on
v0.39.0
Checklist before merging to
draft