sdk/queries/vp/pos: sanitize the input of validator_by_tm_addr
#3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
+ Coverage 54.05% 54.08% +0.02%
==========================================
Files 315 315
Lines 106296 106334 +38
==========================================
+ Hits 57461 57506 +45
+ Misses 48835 48828 -7 ☔ View full report in Codecov by Sentry. |
Fraccaman
added a commit
that referenced
this pull request
Jun 3, 2024
* up/tomas/router-loop: changelog: add #3340 sdk/queries/vp/pos: sanitize the input of `validator_by_tm_addr`
brentstone
added a commit
that referenced
this pull request
Jun 4, 2024
* tomas/router-loop: changelog: add #3340 sdk/queries/vp/pos: sanitize the input of `validator_by_tm_addr`
brentstone
approved these changes
Jun 4, 2024
brentstone
added a commit
that referenced
this pull request
Jun 5, 2024
* origin/tomas/router-loop: changelog: add #3340 sdk/queries/vp/pos: sanitize the input of `validator_by_tm_addr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes an issue where an invalid input to
validator_by_tm_addrmay cause a node crash. The problem is that the parameter is used as an unsanitized string in input tonamada_proof_of_stake::storage_key::validator_address_raw_hash_keywhich only expects valid inputs and panics otherwise.Indicate on which release or other PRs this topic is based on
0.38.1
Checklist before merging to
draft