-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit generic events from tx wasms #3088
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 59.41% 59.61% +0.20%
==========================================
Files 298 298
Lines 92326 92934 +608
==========================================
+ Hits 54853 55401 +548
- Misses 37473 37533 +60 ☔ View full report in Codecov by Sentry. |
4a481d9
to
1ea7a77
Compare
7220e48
to
0ffd059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look great! Will the e2e tests work after hermes update like in the base?
haven't tested, but I think nothing broke between the base and the tip of this branch. I'll make sure to run them again tho, manually |
0ac23e8
to
d3d93fc
Compare
d3d93fc
to
b23270a
Compare
b23270a
to
a123582
Compare
Co-authored-by: yito88 <yuji@phact-columba.com>
a123582
to
9a3e15e
Compare
* origin/tiago/emit-generic-events-wasm: Changelog for #3088 Extend WASM events with the current height in FinalizeBlock Fix IBC unit tests Keep all IBC events in VP pseudo exec ctx Query arbitrary events from VPs Emit and query arbitrary events from wasm txs Change TxEnv def to allow emitting/querying arbitrary events Further remove IBC specific event logic from write log Attempt to unify event kinds under the write log Docstr fixes Match the prefix of an event type Allow extending query matcher with new attrs Write a more accurate docstr on attributes map Impl Hash on events Implement Ord on events Switch to BTreeMap in event attributes Implement AttributesMap on BTreeMap Derive serde traits on events
Describe your changes
Emit core events (i.e.
namada_core::event::Event
) from tx wasms. To this end, we leverage IBC's existing wasm infrastructure.NOTE: IBC e2e tests are expected to fail, just like in the base PR.Indicate on which release or other PRs this topic is based on
#3032
Diff for review: https://github.com/anoma/namada/compare/tiago/generalize-events..tiago/emit-generic-events-wasm
(https://github.com/anoma/namada/pull/3088/files/2fc3cc8bbb6302c1bbb3ccdee26d271ed6bae092..0ac23e8a2d514d30a94abb42eafc8c0d6f5ccebd)
Checklist before merging to
draft