-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint datetime #2849
lint datetime #2849
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2849 +/- ##
=======================================
Coverage 53.88% 53.88%
=======================================
Files 308 308
Lines 100154 100225 +71
=======================================
+ Hits 53966 54008 +42
- Misses 46188 46217 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good to me, just left a comment
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
* origin/tomas/lint-datetime: Update clippy.toml changelog: add #2849 clippy: allow annotate every current date/time usage clippy: disallow method to get current date/time
* origin/tomas/lint-datetime: Update clippy.toml changelog: add #2849 clippy: allow annotate every current date/time usage clippy: disallow method to get current date/time # Conflicts: # clippy.toml
Describe your changes
closes #2793 - any usage of current date/time methods requires an explicit
#[allow(clippy::disallowed_methods)]
Indicate on which release or other PRs this topic is based on
0.31.9
Checklist before merging to
draft