Fix vp_user #2617
Merged
Fix vp_user #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
=======================================
Coverage 53.88% 53.88%
=======================================
Files 308 308
Lines 100154 100154
=======================================
+ Hits 53966 53968 +2
+ Misses 46188 46186 -2 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 20, 2024
Closed
tzemanovic
previously approved these changes
Feb 22, 2024
brentstone
force-pushed
the
brent/fix-vp-user
branch
2 times, most recently
from
6893b23 to
bf67c84
Compare
brentstone
force-pushed
the
brent/fix-vp-user
branch
from
397ac17 to
e897fdf
Compare
This was referenced Feb 28, 2024
brentstone
added a commit
that referenced
this pull request
Mar 3, 2024
brentstone
force-pushed
the
brent/fix-vp-user
branch
from
e897fdf to
7ed073f
Compare
|
@tzemanovic I think we are safe not to update the implicit VP since validator accounts are only Established. Lmk if you can think of another reason to update that too. |
tzemanovic
reviewed
Mar 7, 2024
brentstone
force-pushed
the
brent/fix-vp-user
branch
from
fc4e748 to
06c10ca
Compare
Closed
brentstone
force-pushed
the
brent/fix-vp-user
branch
from
06c10ca to
a92df37
Compare
tzemanovic
approved these changes
Mar 8, 2024
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
brentstone
added a commit
that referenced
this pull request
Mar 9, 2024
* origin/brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
Closed
brentstone
added a commit
that referenced
this pull request
Mar 18, 2024
* origin/brent/fix-vp-user: clarify SK in test changelog: add #2617 fix unjail SE bug + test add parentheses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix the unjailing bug observed in the SE, when unjailing that involves demoting another consensus validator the the below-capacity set is involved.
Closes #2663.
Indicate on which release or other PRs this topic is based on
v0.31.9
Checklist before merging to
draft