Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to avoid panic in host env functions #2478

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix to avoid panic in host env functions #2478

merged 3 commits into from
Jan 31, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 31, 2024 •
edited
Loading

Describe your changes

  • Replace unreachable! with Error
  • Fix amount.spend/recieve to return Result

Indicate on which release or other PRs this topic is based on

v0.30.3

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested review from cwgoes and sug0 January 31, 2024 10:56
cwgoes
cwgoes approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@cwgoes cwgoes mentioned this pull request Jan 31, 2024
Closed
@sug0 sug0 mentioned this pull request Jan 31, 2024
Closed
2 tasks
@brentstone brentstone merged commit c9eefed into main Jan 31, 2024
12 of 15 checks passed
@brentstone brentstone deleted the yuji/fix-hostenv-panic branch January 31, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

@cwgoes cwgoes cwgoes approved these changes

@sug0 sug0 Awaiting requested review from sug0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yito88 @tzemanovic @cwgoes @brentstone