Fix several issue with governance and pgf #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Burn it down 🔥🚒! ...with the right intentions :). |
grarco
previously approved these changes
Jan 26, 2024
Closed
Fraccaman
force-pushed
the
fraccaman/fix-governance-underflow
branch
from
ebaf470 to
31788b4
Compare
Fraccaman
force-pushed
the
fraccaman/fix-governance-underflow
branch
from
96ff8fd to
f1d994d
Compare
Fraccaman
commented
Jan 29, 2024
| .iter() | ||
| .map(|steward| match steward { | ||
| AddRemove::Add(address) => address, | ||
| AddRemove::Remove(address) => address, |
There was a problem hiding this comment.
this is wrong I need to map it to a BTreeSet
Fraccaman
force-pushed
the
fraccaman/fix-governance-underflow
branch
from
f1d994d to
fda71f4
Compare
Fraccaman
force-pushed
the
fraccaman/fix-governance-underflow
branch
from
fda71f4 to
dd5b24f
Compare
Fraccaman
changed the title
grarco
approved these changes
Jan 29, 2024
Fraccaman
pushed a commit
that referenced
this pull request
Jan 29, 2024
* origin/fraccaman/fix-governance-underflow: add changelog check for duplicate in pgf action proposals restrict delegation field validate vote key in governance vp avoid duplicate addresses in pgf steward proposal, use btreeset instead of hashset use validator voting power instead of total voting power avoid logging an underflow, more underflow checks
brentstone
added a commit
that referenced
this pull request
Jan 29, 2024
* origin/fraccaman/fix-governance-underflow: add changelog check for duplicate in pgf action proposals restrict delegation field validate vote key in governance vp avoid duplicate addresses in pgf steward proposal, use btreeset instead of hashset use validator voting power instead of total voting power avoid logging an underflow, more underflow checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A bug was found by @zenodeapp during a public testnet regarding an underflow in governance VP. This PR aims to fix it.
PGFActionfor both pgf steward and pgf funding proposal must have unique targetsPGFActioninto a sorted collection to avoid inconsistent states due to orderingIndicate on which release or other PRs this topic is based on
Checklist before merging to
draft