Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Bridge pool transfer hashes on all whitespace toks #1851

Merged
merged 91 commits into from
Sep 6, 2023
Merged

Split Bridge pool transfer hashes on all whitespace toks #1851

merged 91 commits into from
Sep 6, 2023

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 29, 2023 •
edited
Loading

Describe your changes

Improves the UX of Bridge pool CLI users, by documenting the add-erc20-transfer command a bit better, and allowing an arbitrary number of whitespace tokens to separate transfer hashes.

NOTE: Change the base to main once reviewed.

Indicate on which release or other PRs this topic is based on

#1811

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

sug0 added 30 commits August 28, 2023 09:11
@sug0
Add Eth whitelist storage keys
9ec1833
@sug0
Add Eth whitelist key tests
ed2afb2
@sug0
Add non-usable tokens for Ethereum bridge protocol bookkeeping
6ca25fd
@sug0
Add a VP for NUT transfers
5208f3d
@sug0
Test NUT VP
9c14b65
@sug0
Trigger the NUT native VP
4901296
@sug0
Update ethbridge-rs to v0.19.0
9b6df79
@sug0
Add transfer to Ethereum kinds (ERC20 or NUT)
b932890
@sug0
Mint NUTs upon receiving non-whitelisted assets or exceeding token caps
8297842
@sug0
Add helper fn to whitelist tokens in tests
82320aa
@sug0
Fix unit tests requiring token whitelist checks
1a70c4f
@sug0
Fix refunding and burning of NUTs
339e18a
@sug0
Rework DAI minting unit tests to account for NUTs
d115bb0
@sug0
Test burning NUTs
d26e983
@sug0
Check NUT escrow in Bridge pool VP
8de897d
@sug0
Test NUTs in the Bridge pool
a839866
@sug0
Add NUT cmdline flag for Bridge pool transfers
180c986
@sug0
Update ethbridge-rs to v0.20.0
7732e24
@sug0
Remove whitelist Ethereum events from the ledger
92bb87f
@sug0
Add whitelisted ERC20 tokens to the genesis file
a1213c7
@sug0
Update ethbridge-rs to v0.21.0
4777038
@sug0
Move ethbridge-rs deps to the workspace
cde9503
@sug0
Add changelog entry for the Ethereum token whitelist
20044d0 
Closes #1290
@sug0
Add helper methods to EthAssetMint
2ae23fb
@sug0
Use EthAssetMint helper methods
f1be3f9
@sug0
Refactor redeem_native_token to use update::amount
6ef086f
@sug0
Vet Ethereum bridge config of the native token
f1bd957
@sug0
Harden Bridge pool VP against wNAM NUT transfers
69037fb
@sug0
Update wNAM supplies when acting on Ethereum events
a26de50
@sug0
Allow null pre-balances during Bridge pool escrow checks
c67a656
@sug0 sug0 requested review from batconjurer and tzemanovic August 29, 2023 08:41
@sug0 sug0 mentioned this pull request Aug 29, 2023
Closed
@sug0 sug0 changed the base branch from tiago/fix-bp-recommendations to main August 29, 2023 09:32
@sug0 sug0 changed the base branch from main to tiago/fix-bp-recommendations August 29, 2023 09:32
@sug0 sug0 mentioned this pull request Aug 29, 2023
Merged
2 tasks
tzemanovic
tzemanovic previously approved these changes Aug 29, 2023
View reviewed changes
@sug0 sug0 changed the base branch from tiago/fix-bp-recommendations to main August 29, 2023 10:04
@sug0 sug0 dismissed tzemanovic’s stale review August 29, 2023 10:04

The base branch was changed.

sug0 added a commit that referenced this pull request Aug 30, 2023
@sug0
Merge branch 'tiago/bridge-pool-hashlist' (#1851)
5941b6b
Fraccaman added a commit that referenced this pull request Sep 6, 2023
@Fraccaman
Merge branch 'tiago/bridge-pool-hashlist' (#1851)
0de24d3 
* origin/tiago/bridge-pool-hashlist:
  Changelog for #1851
  Split Bridge pool transfer hashes on all whitespace toks
Fraccaman added a commit that referenced this pull request Sep 6, 2023
@Fraccaman
Merge branch 'tiago/bridge-pool-hashlist' (#1851)
077d160 
* origin/tiago/bridge-pool-hashlist:
  Changelog for #1851
  Split Bridge pool transfer hashes on all whitespace toks
Fraccaman added a commit that referenced this pull request Sep 6, 2023
@Fraccaman
Merge branch 'origin/tiago/bridge-pool-hashlist' (#1851)
6a2f175 
* origin/tiago/bridge-pool-hashlist:
  Changelog for #1851
  Split Bridge pool transfer hashes on all whitespace toks
@Fraccaman Fraccaman merged commit e653044 into main Sep 6, 2023
@Fraccaman Fraccaman deleted the tiago/bridge-pool-hashlist branch September 6, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batconjurer batconjurer batconjurer approved these changes

@tzemanovic tzemanovic tzemanovic left review comments

Assignees
No one assigned
Labels
client ethereum-bridge UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sug0 @tzemanovic @batconjurer @Fraccaman