Namada rollback #1187
Merged
Namada rollback #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbrink
reviewed
Feb 25, 2023
| let key = Key::from(metadata_key.to_owned().to_db_key()); | ||
| let previous_key = | ||
| Key::from(format!("pred/{}", metadata_key).to_db_key()); | ||
| let previous_value = self.read_subspace_val(&previous_key)?.expect( |
There was a problem hiding this comment.
Does this keep track of whether the key was changed in the last block; ie we need to make certain that we only revert to the pred key if it was actually different on block n-1
There was a problem hiding this comment.
As far as I understood these three keys are updated with every block
adrianbrink
reviewed
Feb 25, 2023
| let tendermint_dir = tendermint_dir.as_ref().to_string_lossy(); | ||
|
|
||
| // Rollback tendermint state | ||
| std::process::Command::new(tendermint_path) |
There was a problem hiding this comment.
Are there docs we can link to that explain how Tendermint rollback behaves?
There was a problem hiding this comment.
I wasn't able to find proper documentation for this. We could link this file which contains the help message, or simply include it in the help message of the Namada command
There was a problem hiding this comment.
let's include the link to the code at least
grarco
commented
Mar 1, 2023
grarco
force-pushed
the
grarco/rollback
branch
2 times, most recently
from
1ce3276 to
b553461
Compare
tzemanovic
approved these changes
Mar 8, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 11, 2023
* grarco/rollback: changelog: add 1187 Improves rollback command description Parallel rollback Improves logging in rollback Managing missing keys in rollback Fixes `rollback` iterators Improves rollback docs Adds `rollback` command to cli Improves rollback comments Rollback deletes height-prepended keys Wip Namada rollback
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
rollbackcommand for Namada.The command first calls the
rollbackcommand of Tendermint and then proceeds to reverting the state of the application by:subspacekeys to their previous value based on the diff key of the last height (if any)