Added DJ role support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for the DJ role. Not 100% sure what the ‘set-dj’ means in the roles. According to dub documentation RDJs can only participate in locked queues. DJs shouldn’t be able to do that. So I assumed that it would be exactly that right.
Role DJ has the same rights as RDJ But the role gets removed as soon as queue is unlocked. So role rights are the same.
|
Second commit after I checked how the DJ role works. |
netux
added a commit
to netux/DubAPI
that referenced
this pull request
May 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the DJ role.
Not 100% sure what the ‘set-dj’ means in the roles.
According to dub documentation RDJs can only participate in locked
queues. DJs shouldn’t be able to do that.
So I assumed that it would be exactly that right.