-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use black to auto format code #710
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #710 +/- ##
========================================
Coverage 95.84% 95.84%
========================================
Files 95 95
Lines 5200 5200
========================================
Hits 4984 4984
Misses 216 216
|
@SanketDG can you add the rest of the PR template in your description (relevant parts only)? |
@isabelcosta Done! |
@SanketDG any idea on why this lowers the code coverage by 5%? I feel we have no way around it right 🤔 |
It does not seem to pick up the diff correctly, that's strange. We might have to go with the warning 🙁 |
@Tlazypanda do you know why style fixes would lower the test coverage? 🤔 |
Hey @isabelcosta the codecov report above shows no change am I missing something? 😅 |
@Tlazypanda true 😅 but the code cov check for patch is failing somehow 🤔 |
@SanketDG will you do the GH action step for black formatting on a separate PR or this one? |
@isabelcosta Updated! Unfortunately, Black's github action does not work now 🙁 , it needs a new release psf/black#1520 We can choose to proceed with one of the hacks as mentioned in the issue to get this merged. |
Hey @isabelcosta @SanketDG Ohh my bad I didn't see the test just the comment 😅 I started digging through the issue and found that the codecov/patch check sometimes results in incorrect results and other Opensource orgs have also raised issues to disable this check and only check the codecov/project check for measuring code coverage 😅 Here are some references:- Should we go ahead and remove this check as these Orgs have also done? Thanks ✌️ |
@Tlazypanda Oh interesting! I think we do not need to switch it off since it will work correctly in most cases, but just make the "right" decision to merge the PR irrespective of a false positive check failing. |
@Tlazypanda thank you so much for taking a deeper look at the issue! |
Been travelling for the past three days @isabelcosta This is updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @SanketDG 👏 🎉 So excited about this!
This has gone stale after a cleanup so I have opened #928 |
Description
Use
black
to reformat code, and add instructions for READMEFixes #701
Type of Change:
Code/Quality Assurance Only
Checklist:
requirements.txt
should only contain production + dev deps and I also didn't want to pin a specific version of linting tool )Code/Quality Assurance Only