-
Notifications
You must be signed in to change notification settings - Fork 25.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): drop support for TypeScript 4.4 and 4.5 #45394
Conversation
Shouldn’t we just drop support for TypeScript 4.5 3P like we did in similar cases previously? Otherwise we’d need to support 4.5 until v15. We can still support 4.5 in G3 until the update is completed. The version checks in the compiler-cli and peer dependencies only apply to 3P users anyways. |
I wanted to keep the integration test so that's why I didn't drop it. It's likely that g3 will be on 4.6 before we hit feature freeze so we can drop it then. |
You can still keep the integration test, as that uses TSC and not NGC. Sidenote: the integration tests mainly cover 3P uses cases as the test for backwards compatibility of declaration files which is never the case in G3 as the same version of TypeScirpt is used. But it’s your call as long as we remember to do the breaking change prior of the RC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also prefer to drop both TS 4.4 and TS 4.5 at the same time, and just keep the typings tests around for g3. It would be a single breaking change instead of two, resulting in cleaner release notes (or we'd have to manually update those when the release is cut)
Good point that the integration test only covers 3P, I've removed it in addition to bumping the minimum version to 4.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler. BREAKING CHANGE: TypeScript versions older than 4.6 are no longer supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR was merged into the repository by commit c9d566c. |
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler. BREAKING CHANGE: TypeScript versions older than 4.6 are no longer supported. PR Close angular#45394
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler. BREAKING CHANGE: TypeScript versions older than 4.6 are no longer supported. PR Close angular#45394
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler.
BREAKING CHANGE:
TypeScript versions older than 4.5 are no longer supported.