Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): drop support for TypeScript 4.4 and 4.5 #45394

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 19, 2022

Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler.

BREAKING CHANGE:
TypeScript versions older than 4.5 are no longer supported.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer breaking changes area: core Issues related to the framework runtime target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Mar 19, 2022
@ngbot ngbot bot modified the milestone: Backlog Mar 19, 2022
@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 19, 2022

Shouldn’t we just drop support for TypeScript 4.5 3P like we did in similar cases previously? Otherwise we’d need to support 4.5 until v15.

We can still support 4.5 in G3 until the update is completed. The version checks in the compiler-cli and peer dependencies only apply to 3P users anyways.

@crisbeto
Copy link
Member Author

I wanted to keep the integration test so that's why I didn't drop it. It's likely that g3 will be on 4.6 before we hit feature freeze so we can drop it then.

@crisbeto crisbeto marked this pull request as ready for review March 19, 2022 09:22
@pullapprove pullapprove bot requested review from JoostK and josephperrott March 19, 2022 09:22
@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 19, 2022

You can still keep the integration test, as that uses TSC and not NGC.

Sidenote: the integration tests mainly cover 3P uses cases as the test for backwards compatibility of declaration files which is never the case in G3 as the same version of TypeScirpt is used.

But it’s your call as long as we remember to do the breaking change prior of the RC.

Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also prefer to drop both TS 4.4 and TS 4.5 at the same time, and just keep the typings tests around for g3. It would be a single breaking change instead of two, resulting in cleaner release notes (or we'd have to manually update those when the release is cut)

@crisbeto crisbeto changed the title feat(core): drop support for TypeScript 4.4 feat(core): drop support for TypeScript 4.4 and 4.5 Mar 19, 2022
@crisbeto
Copy link
Member Author

Good point that the integration test only covers 3P, I've removed it in addition to bumping the minimum version to 4.6.

Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler.

BREAKING CHANGE:
TypeScript versions older than 4.6 are no longer supported.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 22, 2022
@crisbeto crisbeto removed the action: presubmit The PR is in need of a google3 presubmit label Mar 23, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Mar 24, 2022

This PR was merged into the repository by commit c9d566c.

@dylhunn dylhunn closed this in c9d566c Mar 24, 2022
PiyushAgrawal1243 pushed a commit to PiyushAgrawal1243/angular that referenced this pull request Mar 30, 2022
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler.

BREAKING CHANGE:
TypeScript versions older than 4.6 are no longer supported.

PR Close angular#45394
josmar-crwdstffng pushed a commit to josmar-crwdstffng/angular that referenced this pull request Apr 8, 2022
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler.

BREAKING CHANGE:
TypeScript versions older than 4.6 are no longer supported.

PR Close angular#45394
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants