fix(@angular/build): update critical CSS inlining to support autoCsp
#29638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
auto-csp-css-inline
branch
3 times, most recently
from
bffc752 to
4dbb4de
Compare
alan-agius4
changed the title
autoCsp to handle inlined critical CSSautoCsp
alan-agius4
force-pushed
the
auto-csp-css-inline
branch
2 times, most recently
from
84366d7 to
c2e79f9
Compare
alan-agius4
force-pushed
the
auto-csp-css-inline
branch
from
c2e79f9 to
57a08c9
Compare
alan-agius4
force-pushed
the
auto-csp-css-inline
branch
5 times, most recently
from
83883d9 to
d0e3f12
Compare
This update improves the handling of inlined critical CSS to align with `autoCsp`, ensuring compliance with Content Security Policy (CSP) directives. Previously, inlined styles could trigger CSP violations in certain configurations. With this fix, critical CSS is inlined in a way that maintains security while supporting `autoCsp`. Closes angular#29603
alan-agius4
force-pushed
the
auto-csp-css-inline
branch
from
d0e3f12 to
4bac5d8
Compare
dgp1130
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM, do we want to wait for @aaronshim to take a look or just merge this as is? Feels more related to critical CSS than AutoCSP really.
|
@dgp1130 ship it! Indeed it’s mostly around critical css inlining. |
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the handling of inlined critical CSS to align with
autoCsp, ensuring compliance with Content Security Policy (CSP) directives. Previously, inlined styles could trigger CSP violations in certain configurations. With this fix, critical CSS is inlined in a way that maintains security while supportingautoCsp.Closes #29603
//cc @aaronshim