fix(@schematics/angular): handle aliased or existing environment import #16377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
changed the title
environment import
clydin
requested changes
Dec 11, 2019
| // Find specifier that contains `environment` keyword in its text. | ||
| // Whether it's `environment` or `environment as env`. | ||
| const nodes = findNodes(declaration, ts.SyntaxKind.ImportSpecifier).filter(node => | ||
| node.getText().includes('environment'), |
There was a problem hiding this comment.
getText can be an expensive operation.
Can you move the named bindings analysis up to this point and use it to check the values?
|
Can you rebase on master? This should fix the failing tests. |
Done. |
clydin
approved these changes
Dec 19, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16226
The exception
Cannot read property 'length' of undefinedwasn't really informative thus I had to find out where this exception was actually thrown. All ways led me to theChunkclass and theinsertLeftmethod that usedbuffer's variablelengthproperty. Thebufferwasundefined, that's why that exception was thrown. It wasundefinedbecause there is no way to check ifenvironmentis already imported.This PR adds the ability to handle the already existing "environment" import or the aliased one.