Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): remove no-bin-links during npm/yarn install #16143

Merged
merged 1 commit into from
Nov 12, 2019
Merged

fix(@angular/cli): remove no-bin-links during npm/yarn install #16143

merged 1 commit into from
Nov 12, 2019

Conversation

alan-agius4
Copy link
Collaborator

Previously we passed --no-bin-links because we used to install packages globally in some cases. But now this is no longer needed as we should now have permissions to generate "local" bin links even during a temp installations as these will no longer generate bin links in the global context.

Fixes #16133

Previously we passed `--no-bin-links` because we used to install packages globally in some cases. But now this is no longer needed as we should now have permissions to generate "local" bin links even during a temp installations as these  will no longer generate bin links in the global context.

Fixes #16133
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 11, 2019
@alan-agius4 alan-agius4 requested a review from clydin November 11, 2019 08:54
@mgechev mgechev merged commit 08c3959 into angular:master Nov 12, 2019
@alan-agius4 alan-agius4 deleted the restore-bin-links branch November 12, 2019 06:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng add @angular/elements nom ERR! Failed at the document-register-element@1.14.3 postinstall script.
4 participants