Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add type option to component schematic #15754

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

leon
Copy link
Contributor

@leon leon commented Oct 3, 2019

the type option allows you to change the default .component.ts suffix to new types.
such as

Route
Dialog
UI
Container

#15680

@vikerman Check it out :)

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 3, 2019
@leon leon force-pushed the feature/component-type branch from 7c88001 to 624b7b0 Compare October 4, 2019 12:23
the type option allows you to change the default .component.ts suffix to new types.
such as

Route
Dialog
UI
Container
@leon leon force-pushed the feature/component-type branch from 624b7b0 to 43e2aa9 Compare October 4, 2019 15:25
@leon leon changed the title feat(@schematics/angular/component): add type option feat(@schematics/angular): add type option to component schematic Oct 4, 2019
@the-ult
Copy link

the-ult commented Oct 8, 2019

Do the Class names get the type names as well?
e.g. UserDetailContainer, CreateUserDialog, etc?

@clydin clydin requested a review from alan-agius4 October 8, 2019 14:42
@leon
Copy link
Contributor Author

leon commented Oct 8, 2019

@the-ult yes they do

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2019
@leon leon deleted the feature/component-type branch November 19, 2019 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants