Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): add sourcemap comment for ES2015 differential loading #15461

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 27, 2019

Fixes #15460

@clydin clydin added the target: patch This PR is targeted for the next patch release label Aug 27, 2019
@clydin clydin requested a review from alan-agius4 August 27, 2019 18:53
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

@clydin clydin force-pushed the fix-downlevel-es2015-sourcemaps branch from 2224f22 to df12773 Compare August 28, 2019 01:14
@clydin
Copy link
Member Author

clydin commented Aug 28, 2019

Yes. Surprised there wasn't already one actually.
Added an E2E that checks that all generated JS has a source map file on disk as well as a corresponding source map comment.

@mgechev mgechev merged commit 0f18e35 into angular:master Aug 28, 2019
mgechev pushed a commit that referenced this pull request Aug 28, 2019
This was referenced Aug 28, 2019
This was referenced Aug 29, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemap with prod build and differential loading does not work with update to 8.3.0
4 participants