Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tsconfig break update process #16019

Closed
filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16063
Closed

Missing tsconfig break update process #16019

filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16063
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Milestone

Comments

@filipesilva
Copy link
Contributor

This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/vmware/clarity.

Having a target that references a missing tsconfig file will prevent ng update from completing:

kamik@RED-X1C6 MINGW64 /d/sandbox/clarity (update-9)
$ ng update @angular/cli @angular/core --next --force
The installed Angular CLI version is older than the latest published version.
Installing a temporary version to perform the update.
Installing packages for tooling via npm.
C:\Users\kamik\AppData\Local\Temp\.ng-temp-packages-6VhtAc\ng -> C:\Users\kamik\AppData\Local\Temp\.ng-temp-packages-6VhtAc\node_modules\@angular\cli\bin\ng

> @angular/cli@9.0.0-rc.0 postinstall C:\Users\kamik\AppData\Local\Temp\.ng-temp-packages-6VhtAc\node_modules\@angular\cli
> node ./bin/postinstall/script.js

+ @angular/cli@9.0.0-rc.0
added 254 packages from 205 contributors in 18.965s
Installed packages for tooling via npm.
Using package manager: 'npm'
Collecting installed dependencies...
Found 109 dependencies.
Fetching dependency metadata from registry...
                  Package "@angular-builders/custom-webpack" has an incompatible peer dependency to "@angular-devkit/build-angular" (requires ">=0.801.0", would install "0.900.0-rc.0").
                  Package "ts-api-guardian" has an incompatible peer dependency to "typescript" (requires "~3.4.0", would install "3.6.4").
    Updating package.json with dependency @angular/cli @ "9.0.0-rc.0" (was "8.3.17")...
    Updating package.json with dependency @angular/core @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/compiler-cli @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/language-service @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular-devkit/build-angular @ "0.900.0-rc.0" (was "0.800.0")...
    Updating package.json with dependency @angular-devkit/build-ng-packagr @ "0.900.0-rc.0" (was "0.800.0")...
    Updating package.json with dependency ng-packagr @ "9.0.0-rc.1" (was "5.2.0")...
    Updating package.json with dependency @angular/compiler @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/common @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/forms @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/platform-browser @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/animations @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency typescript @ "3.6.4" (was "3.4.5")...
    Updating package.json with dependency @angular/platform-server @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/router @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency @angular/platform-browser-dynamic @ "9.0.0-rc.0" (was "8.0.0")...
    Updating package.json with dependency rxjs @ "6.5.3" (was "6.5.2")...
    Updating package.json with dependency zone.js @ "0.10.2" (was "0.9.1")...
UPDATE package.json (13504 bytes)
√ Packages installed successfully.
** Executing migrations of package '@angular/cli' **

>  Update an Angular CLI project to version 9.
Could not find (src/dev/tsconfig.spec.json)
×  Migration failed. See above for further details.

Instead we should warn the user and process with the rest of the update process.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant