feat(@schematics/angular): remove @angular/pwa from depedencies

`@angular/pwa` is not needed as a dependency. This is because the pwa package is a schematic and is only used once when adding pwa capabilities to your application. After that, this package is not used anymore. Closes #15764
angular · Oct 14, 2019 · a7f977f · a7f977f
1 parent d133ba6
commit a7f977f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/schematics/angular/migrations/update-8/update-dependencies.ts b/packages/schematics/angular/migrations/update-8/update-dependencies.ts
@@ -12,7 +12,7 @@ import { latestVersions } from '../../utility/latest-versions';
 export function updateDependencies() {
   return (host: Tree) => {
     const dependenciesToUpdate: Record<string, string> = {
-      '@angular/pwa': latestVersions.AngularPWA,
+      '@angular/pwa': '^0.803.9',
       '@angular-devkit/build-angular': latestVersions.DevkitBuildAngular,
       '@angular-devkit/build-ng-packagr': latestVersions.DevkitBuildNgPackagr,
       '@angular-devkit/build-webpack': latestVersions.DevkitBuildWebpack,

diff --git a/packages/schematics/angular/migrations/update-9/update-dependencies.ts b/packages/schematics/angular/migrations/update-9/update-dependencies.ts
@@ -6,13 +6,16 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import { Rule } from '@angular-devkit/schematics';
-import { addPackageJsonDependency, getPackageJsonDependency } from '../../utility/dependencies';
+import {
+  addPackageJsonDependency,
+  getPackageJsonDependency,
+  removePackageJsonDependency,
+} from '../../utility/dependencies';
 import { latestVersions } from '../../utility/latest-versions';
 
 export function updateDependencies(): Rule {
   return host => {
     const dependenciesToUpdate: Record<string, string> = {
-      '@angular/pwa': latestVersions.AngularPWA,
       '@angular-devkit/build-angular': latestVersions.DevkitBuildAngular,
       '@angular-devkit/build-ng-packagr': latestVersions.DevkitBuildNgPackagr,
       '@angular-devkit/build-webpack': latestVersions.DevkitBuildWebpack,
@@ -35,5 +38,8 @@ export function updateDependencies(): Rule {
         overwrite: true,
       });
     }
+
+    // `@angular/pwa` package is only needed when running `ng-add`.
+    removePackageJsonDependency(host, '@angular/pwa');
   };
 }
diff --git a/packages/schematics/angular/utility/latest-versions.ts b/packages/schematics/angular/utility/latest-versions.ts
@@ -18,7 +18,6 @@ export const latestVersions = {
   DevkitBuildAngular: '~0.900.0-next.9',
   DevkitBuildNgPackagr: '~0.900.0-next.9',
   DevkitBuildWebpack: '~0.900.0-next.9',
-  AngularPWA: '~0.900.0-next.9',
 
   ngPackagr: '^5.5.1',
 };