Remove incorrectly set compileOpions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC that was done to make sure java7 is selected on a host os that also have java8. Should we move this instead under the android block? |
|
|
|
It should default to java 6. So it would still work for java 8. I'll double check to make sure. We shouldn't set compileOptions for the users. |
|
I tested it works with hello-jni arm7Debug. Which project do you mean for app:dexArm7Debug? |
|
Ok, that is fixed now. Please accept the pull request. Thanks |
|
@rschiu, sure can you comment here on the commit/bug that fixed it? thanks. |
proppy
added a commit
that referenced
this pull request
Feb 1, 2016
Remove incorrectly set compileOpions
|
Note that #144 was also fixed the bad scoping of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.