Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shallowCompare for react16 #1

Closed
wants to merge 4 commits into from
Closed

add shallowCompare for react16 #1

wants to merge 4 commits into from

Conversation

yuana1
Copy link

@yuana1 yuana1 commented Apr 12, 2017

shallowCompare was removed from react 16.
facebook/react#9207.

@andrey-skl
Copy link
Owner

Hello!
I just can't get what this pull request is supposed to do.
I did remove all that shallow-compare stuff because it is not needed. But your commit adds it back and just not use it anywhere.

@andrey-skl andrey-skl closed this Apr 12, 2017
@yuana1
Copy link
Author

yuana1 commented Apr 12, 2017

Hi!
I just looked React.PureComponent and found it implements shouldComponentUpdate() with a shallow prop and state comparison.
But HtmlElement.js also has shallowCompare function which doesn't exists in react16.0.0-alpha.
Maybe you need remove these codes?

thanks!

@andrey-skl
Copy link
Owner

andrey-skl commented Apr 12, 2017 •
edited
Loading

No problem!
But I have already removed this import in my master, see
https://github.com/huston007/react-native-fence-html/blob/master/HTMLElement.js
a38a83b

@yuana1
Copy link
Author

yuana1 commented Apr 13, 2017

Sorry i didn't say it clearly.
like this #2
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuana1 @andrey-skl