-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PyPI publishing workflow continued #18
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 348 350 +2
Branches 79 79
=========================================
+ Hits 348 350 +2 ☔ View full report in Codecov by Sentry. |
9f9ad5e
to
50d4453
Compare
name: >- | ||
Publish to PyPI | ||
name: Publish to PyPI | ||
# TODO we need to make sure the tag matches the version! | ||
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
to avoid pushing during a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's not really a problem (?) I think this part is all good.
Enabling verbose will show what the issue is, but it seems the version format is not valid: https://github.com/pypa/gh-action-pypi-publish?tab=readme-ov-file#for-debugging |
Just didn't have time to finish this earlier @gaby . The invalid version is due to the latest valid tag is not picked up (the first one starting with |
TODO:
-dev-<SHORT_SHA>
postfix