Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #173 -- Enabling TLS 1.1 & 1.2 on Android Versions prior to Lollipop #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ModernHttpClient/Android/OkHttpNetworkHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ public NativeMessageHandler(bool throwOnCaptiveNetwork, bool customSSLVerificati

if (customSSLVerification) client.SetHostnameVerifier(new HostnameVerifier());
noCacheCacheControl = (new CacheControl.Builder()).NoCache().Build();

// If less than Android Lollipop
if (((int)Build.VERSION.SdkInt) < 21)
{
client.SetSslSocketFactory(new TlsSSLSocketFactory());
}
}

public void RegisterForProgress(HttpRequestMessage request, ProgressDelegate callback)
Expand Down
79 changes: 79 additions & 0 deletions src/ModernHttpClient/Android/TlsSSLSocketFactory.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
using Javax.Net.Ssl;

namespace ModernHttpClient
{

public class TlsSSLSocketFactory : SSLSocketFactory
{
readonly SSLSocketFactory factory = (SSLSocketFactory)Default;

public override string[] GetDefaultCipherSuites()
{
return factory.GetDefaultCipherSuites();
}

public override string[] GetSupportedCipherSuites()
{
return factory.GetSupportedCipherSuites();
}
public override Java.Net.Socket CreateSocket(Java.Net.InetAddress address, int port, Java.Net.InetAddress localAddress, int localPort)
{
SSLSocket socket = (SSLSocket)factory.CreateSocket(address, port, localAddress, localPort);
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}

public override Java.Net.Socket CreateSocket(Java.Net.InetAddress host, int port)
{
SSLSocket socket = (SSLSocket)factory.CreateSocket(host, port);
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}

public override Java.Net.Socket CreateSocket(string host, int port, Java.Net.InetAddress localHost, int localPort)
{
SSLSocket socket = (SSLSocket)factory.CreateSocket(host, port, localHost, localPort);
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}

public override Java.Net.Socket CreateSocket(string host, int port)
{
SSLSocket socket = (SSLSocket)factory.CreateSocket(host, port);
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}

public override Java.Net.Socket CreateSocket(Java.Net.Socket s, string host, int port, bool autoClose)
{
SSLSocket socket = (SSLSocket)factory.CreateSocket(s, host, port, autoClose);
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}

protected override void Dispose(bool disposing)
{
factory.Dispose();
base.Dispose(disposing);
}

public override Java.Net.Socket CreateSocket()
{
SSLSocket socket = (SSLSocket)factory.CreateSocket();
socket.SetEnabledProtocols(socket.GetSupportedProtocols());
socket.SetEnabledCipherSuites(socket.GetSupportedCipherSuites());

return socket;
}
}
}