Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ModernHttpClient to support .Net 4.5 for shared Windows #175

Closed
wants to merge 1 commit into from

Conversation

kriskats19
Copy link

No description provided.

@anaisbetts
Copy link
Owner

I don't understand this PR at all, why would we do this?

@kriskats19
Copy link
Author

In our project, we are trying to use ModernHttpClient, but we have to support Android, iOS, and Windows. It makes ModernHttpClient work for the Windows Desktop and Windows Phone platform while allowing Native for Android and iOS.

@nberardi
Copy link
Collaborator

nberardi commented Aug 6, 2015

Wouldn't a DI framework easily take care of this situation?

@kriskats19
Copy link
Author

A DI framework could be one solution, but others may run into the same situation while using ModernHttpClient in shared projects. The change will not affect iOS or Android implementations. This solution is much more elegant as a "drop in" replacement for System.Net.Http.

@csunwold
Copy link

csunwold commented Aug 6, 2015

ModernHttpClient is a drop in replacement for HttpMessageHandler on platforms that have platform specific libraries that don't have compatible API's. If you want to use an HttpMessageHandler on a Windows system, just use it. HttpMessageHandler is the abstraction, you dont need to pile any more abstraction on top of it.

@anaisbetts
Copy link
Owner

Yeah, I don't think you need to do this, the PLib should shim it in anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants