Include template files #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed template.rs to use the included template files using the code generated by the build script. It should be noted that this commit removes the awareness of template types.
|
This is the first time I've written Rust. I'm open to suggestions and feedback, even if it's simply idiomatic changes. |
torkleyy
reviewed
Jun 13, 2019
BradLugo
force-pushed
the
include-templates
branch
from
faf8435 to
55eaf02
Compare
|
https://travis-ci.org/amethyst/tools/jobs/545270691#L635 - liquid doesn't build anymore. |
|
also see rust-lang/rust#60958 (comment) |
|
Is this blocking the PR? I can look into liquid's repo and see if this is an issue in the current version, and I can open an issue to do a general upgrade for this project, moving to Rust 2018 and upgrading the other packages. I can encompass the liquid build issue along with any other packages that might break the build. |
|
It's failing CI, but I guess I can merge like this. |
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the build script functionality back and changes
deployto use the included files.Note that the build script doesn't account for different templates, only
maintemplates. Thus,deploydoesn't change its behavior based on thetemplateparameter. I'll open an issue to add functionality to determine more templates if and when this PR is merged.Closes #71