Adds binary read support for macro invocation headers. #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Jun 27, 2024
tgregg
force-pushed
the
read-macro-invocation-headers
branch
from
81ef1da to
34d6211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allows IonCursorBinary to parse macro addresses from all macro invocation opcodes defined in the proposed Ion 1.1 spec. Depends on the system symbol / macro proposal here: amazon-ion/ion-docs#326.
Future PRs will add the ability for higher-level readers to resolve these macro addresses to macro definitions and evaluate the invocations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.