-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tunes the initial size of various reusable ArrayLists to reduce required growth when processing real-world data. #1048
Open
tgregg
wants to merge
1
commit into
ion-11-encoding-optimize-initial-expression-array-size-session-pools-merge-presencebitmap-pool-no-lambdas-no-arraylistitr
Choose a base branch
from
ion-11-encoding-optimize-initial-expression-array-size-session-pools-merge-presencebitmap-pool-no-lambdas-no-arraylistitr-tune
base: ion-11-encoding-optimize-initial-expression-array-size-session-pools-merge-presencebitmap-pool-no-lambdas-no-arraylistitr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,7 +25,7 @@ public abstract class EExpressionArgsReader { | |||||
private final ReaderAdapter reader; | ||||||
|
||||||
// Reusable sink for expressions. | ||||||
protected final List<Expression.EExpressionBodyExpression> expressions = new ArrayList<>(16); | ||||||
protected final List<Expression.EExpressionBodyExpression> expressions = new ArrayList<>(128); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
protected final PooledExpressionFactory expressionPool = new PooledExpressionFactory(); | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -21,8 +21,8 @@ internal class MacroCompiler( | |||||||||
var macroName: String? = null | ||||||||||
private set // Only mutable internally | ||||||||||
|
||||||||||
private val signature: MutableList<Macro.Parameter> = mutableListOf() | ||||||||||
private val expressions: MutableList<TemplateBodyExpression> = mutableListOf() | ||||||||||
private val signature: MutableList<Macro.Parameter> = ArrayList(16) | ||||||||||
private val expressions: MutableList<TemplateBodyExpression> = ArrayList(64) | ||||||||||
Comment on lines
+24
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
/** | ||||||||||
* Compiles a template macro definition from the reader. Caller is responsible for positioning the reader at—but not | ||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -55,7 +55,7 @@ class MacroEvaluator { | |||||
/** Pool of [Expression] to minimize allocation and garbage collection. */ | ||||||
val expressionPool: PooledExpressionFactory = PooledExpressionFactory() | ||||||
/** Pool of [ExpansionInfo] to minimize allocation and garbage collection. */ | ||||||
private val expanderPool: ArrayList<ExpansionInfo> = ArrayList(32) | ||||||
private val expanderPool: ArrayList<ExpansionInfo> = ArrayList(64) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
private var expanderPoolIndex = 0 | ||||||
|
||||||
/** | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.