-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTML escaping problems #53
Conversation
Thanks for the PR. I haven't touched Rails in forever. Can this be verified in a test case? |
@daniel-rikowski Do you have some time to resolve the conflicts? Thank you! |
I wrote a test to verify how it works today. Could you update the test to verify this change? |
Oh, sorry, I didn't notice #65 🙈 I updated the test and added a new one for the ActiveRecord subclass bug, i.e. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This fixes #50 resp. awesome-print/awesome_print#199
Also this prevents the ActiveRecord formatters from emitting unescaped
#<ClassName#object_id>
orClass < Superclass
strings, which couldn't be catched by the caller even with manual escaping.Existing code using workarounds like
<%= raw ap ... %>
or<%= (ap ...).html_safe %>
will continue to work.