Fix formatting ActionController::Parameters #29
Conversation
Add an extra check for unpermitted Rails paramters that will report they they respond to :to_hash but raise an error. Fixes #17
There was a problem hiding this comment.
@HarlemSquirrel almost ready to merge. Just wondering about that regexp 😅
spec/ext/active_record_spec.rb
Outdated
| @@ -259,7 +259,7 @@ class SubUser < User { | |||
| expect(out).to match( | |||
| /\s*first\(\*args,\s+&block\)\s+#<Class:ActiveRecord::Base> \(ActiveRecord::Querying\)/ | |||
| ) | |||
| elsif RUBY_VERSION >= '2.4.4' | |||
| elsif RUBY_VERSION =~ /2\.[4-6]\.([4-9]|[1-9][0-9])/ | |||
There was a problem hiding this comment.
Why exactly that regexp? Why not =~ /2\.[4-6]\.\d+/ or simply >= '2.4.0' since the branch for 2.7 is above? Or >= '2.4.0' && < '2.7.0'?
There was a problem hiding this comment.
So we need to find version greater than or equal to 2.4.4 and now that 2.4.10 is out, the string comparison fails with that version.
'2.4.3' >= '2.4.4'
# => false
'2.4.4' >= '2.4.4'
# => true
'2.4.10' >= '2.4.4'
# => false
'2.4.3' =~ /2\.[4-6]\.([4-9]|[1-9][0-9])/
# => nil
'2.4.4' =~ /2\.[4-6]\.([4-9]|[1-9][0-9])/
# => 0
'2.4.10' =~ /2\.[4-6]\.([4-9]|[1-9][0-9])/
# => 0There was a problem hiding this comment.
I see. But the restrictions then also apply to Ruby 2.5 and 2.6.
How about: /^2\.4\.([4-9]|[1-9][0-9])|^2\.[56]\./
|
OK, I had to run |
Add an extra check for unpermitted Rails paramters
that will report they they respond to :to_hash
but raise an error.
Fixes #17