Add mapKeysPartial
and mapValuesPartial
to EntryStream
#280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating over an
EntryStream
, a common pattern is to call a mapping function on the keys or values that returns anOptional<K>
orOptional<V>
. As is, one can remove empty Optionals by usingflatMap(Keys|Values)(Optional::stream)
ormapTo(Key|Value)Partial(partialFunction)
:The former introduces an extra allocation for every entry, while the latter isn't the most ergonomic solution.
As a result, this PR implements
EntryStream.mapKeysPartial
andEntryStream.mapValuesPartial
, which takes a partial key/value mapperFunction<K, Optional<KK>>
and returns anEntryStream<KK, V>
with the empty optionals removed. This makes it possible to now do the following: