Issue/#91 re-structure tests #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts. |
# Conflicts: # src/test/java/one/util/streamex/TestHelpers.java # src/test/java/one/util/streamex/api/DoubleStreamExTest.java # src/test/java/one/util/streamex/api/IntStreamExTest.java # src/test/java/one/util/streamex/api/LongStreamExTest.java # wiki/CHANGES.md
|
Final improvements for StreamEx tests:
|
|
Tagir, could you please give your feedback? |
amaembo
requested changes
Aug 22, 2020
src/test/java/one/util/streamex/MoreCollectorsInternalTest.java
Outdated
Show resolved
Hide resolved
- move some asserts to API tests. - some cosmetics(empty line ane etc.) - remove explicit Assert qualifiers - remove duplicated test from internal
amaembo
requested changes
Aug 30, 2020
- explicit qualifiers
- explicit qualifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final results: 471 tests = 393 API tests + 78 internal tests
Some additional points:
Currently latest JUnit 4 Generation is used - 4.12 .
What do you think about using 5G(jupiter)?
It will allow to use more functional approach(lambdas) even for testing itself. Ane even more: extensions, conditions, parameterized tests, dynamic tests and etc.
What if we apply grouping: categories in JUnit 4G or tags in JUnit 5G?
F.e. we can split all test to 2 categories/tags:
From the documentation :
tags are used to filter which tests are executed for a given test plan. For example, a development team may tag tests with values such as "fast", "slow", "ci-server", etc. and then supply a list of tags to be used for the current test plan, potentially dependent on the current environment.