[smf] add timeouts for Diameter (Gx/Gy) messages #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencersevilla
added a commit
that referenced
this pull request
Feb 1, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 7, 2023
spencersevilla
added a commit
that referenced
this pull request
Jan 17, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 20, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 20, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a Diameter message does not receive a response, the SMF state machine effectively deadlocks while waiting for a response. This PR fixes this by implementing two timers (one for Gx and another for Gy) that allow the code to successfully error-out and recover into a workable state. I do note that Diameter is usually run over a reliable transport protocol (TCP/SCTP) which makes drops somewhat uncommon, but they are still possible in various contexts (e.g. the PCRF deadlocks or crashes, MTU issues across the network, etc) and this is just best-practice in terms of defensive codewriting.