[smf][sgwc] fix upf/sgwc assignment when no_pfcp_rr_select: true #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencersevilla
added a commit
that referenced
this pull request
Jan 28, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 1, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 1, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 3, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 3, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 8, 2023
spencersevilla
added a commit
that referenced
this pull request
Mar 7, 2023
spencersevilla
added a commit
that referenced
this pull request
Jan 17, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently written, if the no_pfcp_rr_select option is set to true and there are no suitable SGWC or UPF for a given UE, the code will simply return the first UPS node regardless of whether it's even attached or not, which could cause some obscure issues later. Correct/expected behavior in this context is to reject the UE.