allow fine-grained setting of message timers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2023
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2023
spencersevilla
added a commit
that referenced
this pull request
Jan 31, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 1, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 6, 2023
spencersevilla
added a commit
that referenced
this pull request
Feb 7, 2023
spencersevilla
added a commit
that referenced
this pull request
Mar 7, 2023
spencersevilla
added a commit
that referenced
this pull request
Jan 17, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 19, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 19, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the timeout/retransmit values for almost all messages (GTP, PFCP, SBI, Diameter) are set to message.duration (default value 10sec). Having all these timers set to the same value can create weird race-conditions when something times out; to this point the 3GPP specifically recommends fine-tuning these parameters to appropriate values. For example, mme->sgwc GTPv2 messages should naturally have a longer timeout than sgwc->smf GTPv2 messages or sgwc->sgwu PFCP messages. This PR addresses this limitation by breaking up message.duration into sub-parameters (gtp_duration, sbi_duration, pfcp_duration), each of which is individually configurable.