Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy merkle tree merkle proof logic #1

Conversation

chancehudson
Copy link

Description

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Owner

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! assuming tests pass locally.

@alrevuelta
Copy link
Owner

lgtm on my side. @vimwitch Ready to be merged? Unsure if you have permission since it's in my fork.

@chancehudson
Copy link
Author

Yes, we'll merge this into your fork, then your fork into zk-kit/main

@alrevuelta
Copy link
Owner

@vimwitch Anything left here? lgtm on my side.

@chancehudson
Copy link
Author

I think it's ready, this is your repo though so I can't merge it.

@alrevuelta alrevuelta merged commit 28cdb54 into alrevuelta:get-merkle-proof Mar 5, 2024
alrevuelta added a commit that referenced this pull request Apr 23, 2024
…ions#162)

* feat: add get merkle proof to lazy imt tree

* chore: run prettier

* chore: fix lint problems

* chore: remove proof index + misc changes

* chore: run prettier

* chore: move revert inside loop

* chore: take snapshoot in each test

* Lazy merkle tree merkle proof logic (#1)

* chore: fix eslint problems

---------

Co-authored-by: Chance <jchancehud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants