Fix Error with regexp Stack Overflows #131
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll try to merge this soon. |
|
Great, no rush 🙂 |
I have the same problem. |
Fix "error in process sentinel: Wrong type argument: magit-todos-item, t" occurring when there's a stack overflow in the regexp matcher, which is caught and then a warning displayed, but since display-warning returns a truthy value (t) this truthy value is treated as a valid todo item by the enclosing --when-let. The error is then thrown later when Emacs tries to write its the TODO item in the magit status buffer.
alphapapa
force-pushed
the
regexp-overflow-fix
branch
from
8d37c49 to
3274451
Compare
|
@LaurenceWarne Thanks for your patience. @b40yd Thanks for reminding me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I kept getting
error in process sentinel: Wrong type argument: magit-todos-item, twhenever I opened the magit status buffer for a file in the https://github.com/github/linguist repo.I found that when a stack overflow occurred during regexp matching
(display-warning 'magit-todos (concat "File has lines too long for Emacs to search. Consider excluding it from scans: " filename))was returningt, which was causing the enclosing--when-letto treat thetas a todo item and add it to the list of todo items, which caused the above error when writing it to a buffer.AFAICS the doc for
display-warningdoesn't say anything about its return value ((display-warning 'foo "foo")returnst🤷), so for surety this PR just addsnilto the next line.I can reproduce it with minimal config using the following:
git clone https://github.com/github/linguist(though I think any repo with an uber line will do, e.g. this file is the culprit in that repo: https://github.com/github/linguist/blob/master/test/fixtures/Data/bootstrap.css.map)./makem.sh interactivemagit-todos-mode,magitThanks!