Transport based header #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #logo { | ||
| @include core-48; | ||
| font-size: 28pt; | ||
| font-weight: bold; |
There was a problem hiding this comment.
Purely inexperience. :)
This is better than putting it in robots.txt. See #363
selfthinker
added a commit
to alphagov/govuk_template
that referenced
this pull request
Aug 11, 2016
* Setting width and height via CSS is not necessary anymore since the dimensions were set in the HTML in c0e8bd3 * Removing the border on the logo img is not necessary anymore as it was removed on all images globally in db43128 * Setting `display` on the image is not necessary as it's also floating and everything that floats is always `display: block` * Setting a `line-height` has no effect on replaced elements like images * When the styling for the current print logo was changed in 0704a5e the old styling was not removed * Using `core-48` together with redefining the font-size and font-weight is (nearly) the same as using `bold-80`, the original PR alphagov/static#352 mentions that this was not intentional
selfthinker
added a commit
to alphagov/govuk_template
that referenced
this pull request
Aug 23, 2016
* Setting width and height via CSS is not necessary anymore since the dimensions were set in the HTML in c0e8bd3 * Removing the border on the logo img is not necessary anymore as it was removed on all images globally in db43128 * Setting `display` on the image is not necessary as it's also floating and everything that floats is always `display: block` * Setting a `line-height` has no effect on replaced elements like images * When the styling for the current print logo was changed in 0704a5e the old styling was not removed * Using `core-48` together with redefining the font-size and font-weight is (nearly) the same as using `bold-80`, the original PR alphagov/static#352 mentions that this was not intentional
selfthinker
added a commit
to alphagov/govuk_template
that referenced
this pull request
Sep 19, 2016
* Setting width and height via CSS is not necessary anymore since the dimensions were set in the HTML in c0e8bd3 * Removing the border on the logo img is not necessary anymore as it was removed on all images globally in db43128 * Setting `display` on the image is not necessary as it's also floating and everything that floats is always `display: block` * Setting a `line-height` has no effect on replaced elements like images * When the styling for the current print logo was changed in 0704a5e the old styling was not removed * Using `core-48` together with redefining the font-size and font-weight is (nearly) the same as using `bold-80`, the original PR alphagov/static#352 mentions that this was not intentional
selfthinker
added a commit
to alphagov/govuk_template
that referenced
this pull request
Sep 29, 2016
* Setting width and height via CSS is not necessary anymore since the dimensions were set in the HTML in c0e8bd3 * Removing the border on the logo img is not necessary anymore as it was removed on all images globally in db43128 * Setting `display` on the image is not necessary as it's also floating and everything that floats is always `display: block` * Setting a `line-height` has no effect on replaced elements like images * When the styling for the current print logo was changed in 0704a5e the old styling was not removed * Using `core-48` together with redefining the font-size and font-weight is (nearly) the same as using `bold-80`, the original PR alphagov/static#352 mentions that this was not intentional This was only changed to `bold-48`, not `bold-80` because of a bug in govuk_frontend_toolkit, see alphagov/govuk_frontend_toolkit#328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new text-based header on print pages, rather than the three-versions-in-one looks-like-a-bug header.