Upgrade Smart Answers to Ruby 2.2.4 #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI isn't setup with 2.2.4 yet |
erkde
force-pushed
the
upgrade_to_ruby_2_2_4
branch
from
bf072bf to
cfa7be0
Compare
|
It looks as if Ruby 2.2.4 was added to ci-puppet in alphagov/ci-puppet#375 which has been merged. I'm going to try kicking the CI build for this PR and see whether it now passes. |
|
The CI build has now passed, so I assume that Ruby 2.2.4 is now available on production. I've reviewed the changes and they look good to me. The branch is up-to-date with master and ready for merging. |
|
Ok, let's give this a try |
erkde
pushed a commit
that referenced
this pull request
Feb 4, 2016
Upgrade Smart Answers to Ruby 2.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version for Ruby from 2.2.3 to 2.2.4, which fixes CVE-2015-7551 of Ruby's Fiddle and DL modules, neither which Smart Answer uses directly.
Stage
https://warm-shelf-8029.herokuapp.com/am-i-getting-minimum-wage