Merge pull request #3182 from alphagov/revert-embed-optimisation

Revert "Do not loop through details unless embed links exist"
alphagov · Mar 7, 2025 · 6855ad5 · 6855ad5
2 parents 0605762 + 0c784c2
commit 6855ad5
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/app/presenters/content_embed_presenter.rb b/app/presenters/content_embed_presenter.rb
@@ -5,8 +5,6 @@ def initialize(edition)
     end
 
     def render_embedded_content(details)
-      return details unless target_content_ids
-
       details.each_pair do |field, value|
         next if value.blank?
 
@@ -18,15 +16,13 @@ def render_embedded_content(details)
 
   private
 
-    def target_content_ids
-      @target_content_ids ||= @edition
-                                .links
-                                .where(link_type: "embed")
-                                .pluck(:target_content_id)
-    end
-
     def embedded_editions
       @embedded_editions ||= begin
+        target_content_ids = @edition
+         .links
+         .where(link_type: "embed")
+         .pluck(:target_content_id)
+
         embedded_edition_ids = ::Queries::GetEditionIdsWithFallbacks.call(
           target_content_ids,
           locale_fallback_order: [@edition.locale, Edition::DEFAULT_LOCALE].uniq,