notify api clients: use a common thread-local requests.Session
#5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to share the same connection pool between the >20 api client instances we have, providing better utilization
CrystalPea
reviewed
Mar 4, 2025
| @@ -13,7 +13,7 @@ pyexcel-io==0.6.6 | |||
| pyexcel-xls==0.7.0 | |||
| pyexcel-xlsx==0.6.0 | |||
| pyexcel-ods3==0.6.1 | |||
| notifications-python-client==10.0.0 | |||
| notifications-python-client @ git+https://github.com/alphagov/notifications-python-client.git@5eafd129144f5006e2d7bf501a9c38450979d4b6 | |||
There was a problem hiding this comment.
so I can see this is a TEMP bump - what plan do we have to ensure this temp doesn't become a semi-permanent thing that will throw someone later?
Also is there a PR for these python client changes that needs reviewing?
There was a problem hiding this comment.
☝️ linked in the PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on alphagov/notifications-python-client#255
We're currently dividing the effectiveness of any connection-pooling we're doing to api-web by >20x by having a separate connection pool per sub-api-client. This contributes to the excessive number of GreenThreads api-web needs to keep active when it has keepalive enabled.
Instead keep a single (lazily-constructed)
requests.Sessionper-thread which gets injected into each sub-api-client at lazy-construction-time.