Fix 'Change' links on settings page #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borrowed from v5 of govuk-frontend which includes the changes from this pull request to fix an issue with how certain screen readers announce spaces in visually hidden text: alphagov/govuk-frontend#3836
quis
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/k4m4g5C6/566-fix-issues-with-change-links-on-settings-page
Fixes the following issues:
Note: the second issue copies this fix from the Design System v5.
Notes for reviewers
I tested this in JAWS and NVDA, the screen readers with the problem announcing visually hidden text, and all sounding as intended. Same in Voiceover on Mac.
Given that, reviews can just be based on the logic of changes and whether they adversely affect the visual interface.