Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some letter spacing to textboxes that accept digits #1545

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Add some letter spacing to textboxes that accept digits #1545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/assets/stylesheets/components/textbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,8 @@
.textbox-right-aligned {
text-align: right;
}

.extra-tracking .form-control {
padding-left: 5px;
letter-spacing: 0.04em;
}
4 changes: 3 additions & 1 deletion app/templates/views/register-from-invite.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ <h1 class="heading-large">Create an account</h1>
<p>Your account will be created with this email: {{email_address}}</p>
<form method="post" autocomplete="off">
{{ textbox(form.name, width='3-4') }}
{{ textbox(form.mobile_number, width='3-4', hint='We’ll send you a security code by text message') }}
<div class="extra-tracking">
{{ textbox(form.mobile_number, width='3-4', hint='We’ll send you a security code by text message') }}
</div>
{{ textbox(form.password, hint="At least 8 characters", width='3-4') }}
{{ page_footer("Continue") }}
{{form.service}}
Expand Down
4 changes: 3 additions & 1 deletion app/templates/views/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ <h1 class="heading-large">Create an account</h1>
<form method="post" novalidate>
{{ textbox(form.name, width='3-4') }}
{{ textbox(form.email_address, hint="Must be from a government organisation", width='3-4', safe_error_message=True) }}
{{ textbox(form.mobile_number, width='3-4', hint='We’ll send you a security code by text message') }}
<div class="extra-tracking">
{{ textbox(form.mobile_number, width='3-4', hint='We’ll send you a security code by text message') }}
</div>
<input class="visually-hidden" aria-hidden="true" tabindex="-1" id="defeat-chrome-autocomplete">
{{ textbox(form.password, hint="At least 8 characters", width='3-4') }}
{{ page_footer("Continue") }}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/views/send-test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h1 class="heading-large">

<form method="post" class="js-stick-at-top-when-scrolling" data-module="autofocus" autocomplete="off">
<div class="grid-row">
<div class="column-two-thirds">
<div class="column-two-thirds {% if form.placeholder_value.label.text == 'phone number' %}extra-tracking{% endif %}">
{{ textbox(
form.placeholder_value,
hint='Optional' if optional_placeholder else None,
Expand Down
2 changes: 1 addition & 1 deletion app/templates/views/two-factor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ <h1 class="heading-large">Check your phone</h1>

<p>We’ve sent you a text message with a security code.</p>

<form autocomplete="off" method="post">
<form autocomplete="off" method="post" class="extra-tracking">
{{ textbox(
form.sms_code,
width='5em',
Expand Down