Allow overriding / removal of OGL logo in the footer #189
Conversation
… licenceLogo template parameter
| @@ -110,7 +110,12 @@ | |||
| <%= yield :footer_support_links %> | |||
|
|
|||
| <div class="open-government-licence"> | |||
| <p class="logo"><a href="https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/" rel="license">Open Government Licence</a></p> | |||
| <% if content_for?(:licence_logo) %> | |||
| <%= yield :licence_logo %> | |||
There was a problem hiding this comment.
There doesn't seem to be an obvious way to remove the logo without providing an alternative.
How would you use this in your app?
There was a problem hiding this comment.
@fofr I guess I would override it with a zero length string in my local copy of this file:
https://github.com/alphagov/govuk_elements/blob/master/lib/template-config.js
Though I could be wrong. Part of the difficulty with this kind of thing is the need to target so many templating languages?! I.e. with mustache being "logicless"
There was a problem hiding this comment.
Using an empty string doesn't feel like the right way of achieving this.
There was a problem hiding this comment.
@fofr I don't disagree with you, just not sure what the alternative would be within the constraints of the multiple templating languages we have to deal with?
Happy for this PR to be declined for now though until a better solution comes up...
|
Hey @andymantell did you manage to work around this? Want to see if we can get this resolved.. |
|
@NickColley Yeah I just edited the template we were using. Probably just worth declining this PR, it may only be me that even wanted this. And I don't know that my proprosed changes were necessarily the right way of doing it. |
|
Okay, feel free to reopen if anything changes 👍 |
As per #188, I am working on a service for which I have been asked to remove the OGL logo and message from the footer. The reason being that some of the information contains personal information such as names and addresses and is not "open". In addition, users are required to purchase the information - it is not freely available.
I have tried to follow the conventions used by the licence message in the footer but I am quite new to using the kit so not 100% sure if I have done this in the right way.
One thing I am aware of is that I might need to make a corresponding change to this file in the govuk_elements repo? https://github.com/alphagov/govuk_elements/blob/master/lib/template-config.js